Fix severe warning from class loader in servo (backport #3577) #3648
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add class loader member variable instead of creating on stack * Fix formatting to satisfy clang --------- Co-authored-by: AndyZe <andyz@utexas.edu> Co-authored-by: Nathan Brooks <nathanbrooks@picknik.ai> (cherry picked from commit 92654dd)
nbbrooks
approved these changes
Dec 15, 2025
Contributor
|
The humble/jazzy/rolling CI jobs should not be running on PRs against kilted :( |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## kilted #3648 +/- ##
==========================================
- Coverage 46.26% 0.00% -46.25%
==========================================
Files 720 207 -513
Lines 62708 23096 -39612
Branches 7592 3145 -4447
==========================================
- Hits 29006 0 -29006
+ Misses 33535 23096 -10439
+ Partials 167 0 -167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To fix "SEVERE WARNING" from class loader in moveit_servo, created the class loader as a member variable instead of creating it on the stack.
This fixes the following error:
This is an automatic backport of pull request #3577 done by [Mergify](https://mergify.com).